fix: clear stale client registration on re-login after token expiry - #4
Merged
Conversation
When tokens expire and refresh fails, TokenManager clears tokens but leaves the DCR client registration. Subsequent login attempts reuse the stale client, causing a crash. Now login clears the client when no tokens exist, and does best-effort cleanup on token exchange failure. Also fixes pre-existing lint warnings (unused imports, non-null assertions in test files) and disables noNonNullAssertion for tests in biome config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nathanBurg
commented
Mar 25, 2026
nathanBurg
left a comment
nathanBurg
left a comment
Contributor
Author
There was a problem hiding this comment.
@jlitola I need to give it about a day to actually test this and make sure the fix works.
jlitola
approved these changes
Mar 25, 2026
nathanBurg
added a commit
that referenced
this pull request
Mar 28, 2026
Publishes the expired-login fix (PR #4) to npm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users and AI agents (Claude Code, Gemini CLI) experience a "cannot read properties of id" crash when running
githits loginafter their session expires. The only workaround is to rungithits logoutfirst, which is poor UX — especially for automated workflows.The root cause: when tokens expire and refresh fails,
TokenManagerclears the tokens but leaves the DCR client registration behind. The nextlogincall sees no tokens, skips the expired-token path, but reuses the stale client registration — which the server has already invalidated.This fix clears the client registration when no tokens exist (so a fresh DCR happens) and does best-effort cleanup on token exchange failure. It also adds 5 new tests and fixes pre-existing lint warnings across test files.
Test plan
bun run typecheckpassesbun run format:checkpassesbun run lintpasses (0 warnings)bun run buildsucceedsbun test— 249 tests pass🤖 Generated with Claude Code