fix: preserve keychain read failures - #240
Merged
Merged
Conversation
Keep missing credentials distinct from keychain access failures in the migrating storage layer. This prepares the CLI to surface errors once the upstream @napi-rs/keyring read fix is released.
skvark
marked this pull request as ready for review
July 30, 2026 07:00
Document that the downstream error handling is safe to merge now but remains inactive for read failures until keyring-node#136 is released and adopted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nulland continue refusing implicit plaintext fallbackWhy
This is the downstream half of Brooooooklyn/keyring-node#136.
@napi-rs/keyring@1.3.0currently collapses keychain read failures and missing entries to the samenullresult. The upstream PR changes that boundary so only a genuine missing entry returnsnull; access and platform failures throw.Our migration layer was independently catching those thrown failures and returning
nullagain. This PR removes that second error-collapsing boundary so a fixed keyring release will produce actionable storage guidance instead of an unauthenticated result.Important
This PR is safe to merge before the upstream release. With
@napi-rs/keyring@1.3.0, the changed read paths remain inactive because the dependency still returnsnull; therefore this PR alone does not resolve the reported macOS behavior for installed users.The release and dependency-bump work is tracked separately in #241.
Validation
Authenticated live smoke coverage reached the backend successfully but was subsequently rate-limited with HTTP 429.