Update PCControllerDriver.groovy: Convert boolean attribute to enum - #3
Open
LibraSun wants to merge 1 commit into
Open
Update PCControllerDriver.groovy: Convert boolean attribute to enum#3LibraSun wants to merge 1 commit into
LibraSun wants to merge 1 commit into
Conversation
…enum Because of the way Rule Machine and other apps set/get device attribute values, the Hubitat platform requires preset values to be listed within an enum structure. This applies to true/false values as well, which should be treated as strings rather than Boolean truth values. I'm proposing such changes to two of the attributes in PC Controller's device driver for maximum compatibility and to avoid certain warnings in RM5.1. Unfortunately, it's unclear whether @gilshallem is still active on github, as he seems to have left the Hubitat Community years ago, and I've been unable to reach him through other channels for a while now. If it's helpful to all parties involved, I'd gladly "adopt" (maintain) this particular integration going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…enum
Because of the way Rule Machine and other apps set/get device attribute values, the Hubitat platform requires preset values to be listed within an enum structure. This applies to true/false values as well, which should be treated as strings rather than Boolean truth values. I'm proposing such changes to two of the attributes in PC Controller's device driver for maximum compatibility and to avoid certain warnings in RM5.1. Unfortunately, it's unclear whether @gilshallem is still active on github, as he seems to have left the Hubitat Community years ago, and I've been unable to reach him through other channels for a while now. If it's helpful to all parties involved, I'd gladly "adopt" (maintain) this particular integration going forward.