Skip to content

updated and expanded authorship file - #12

Open
ThePeach wants to merge 10 commits into
gilesbowkett:masterfrom
ThePeach:master
Open

updated and expanded authorship file#12
ThePeach wants to merge 10 commits into
gilesbowkett:masterfrom
ThePeach:master

Conversation

@ThePeach

Copy link
Copy Markdown

Hi and thanks for the work done on this repo.
I've taken the liberty of updating and expanding one of the scripts in order to extract a bit more information from the files.
I've also added a bunch of flags to control the output: it can now return:

  • the authors (as it was before)
  • the files and the list of authors ordered by number of commits
  • the files ordered by total number of commits
  • the files ordered by total number of commits with the list of authors ordered by number of commits.

while still be able to filter the files by extension.

I have not much experience in Ruby, but it did make sense to me to reduce the number of requirements for this simple script.

Let me know if there's anything you'd like to have it outputted differently or updated/refactored in a different way.

M.

Comment thread basic_stats.sh Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilesbowkett

Copy link
Copy Markdown
Owner

Thanks for the work here, and sorry re the delay in responding. I'll have to dig into this, but if I use it, I'd definitely rename basic_stats. It's a very general name, and, when sitting next to a file named file_stats, also takes on some redundancy. The -o option is much faster than tally_authors, although other flags seemed slower in a large repo (informal, groggy, early morning assessment here; no actual benchmarking done).

@ThePeach

ThePeach commented Aug 6, 2015

Copy link
Copy Markdown
Author

thanks for the reply @gilesbowkett, feel free to take whatever you need from it, also if you want I can jump in and adapt some of this into something more specific if you prefer.

@ThePeach

Copy link
Copy Markdown
Author

@gilesbowkett I've done the required changes (a bit late, but here you go) and fixed the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants