Add accelerators to page/extension menus#1425
Open
eugenesvk wants to merge 1 commit intogildas-lormeau:masterfrom
Open
Add accelerators to page/extension menus#1425eugenesvk wants to merge 1 commit intogildas-lormeau:masterfrom
eugenesvk wants to merge 1 commit intogildas-lormeau:masterfrom
Conversation
also add icons for faster visual differentiation
b419846 to
7f693ce
Compare
wisdoms6969
approved these changes
Apr 5, 2024
wisdoms6969
approved these changes
Apr 5, 2024
wisdoms6969
approved these changes
Apr 5, 2024
wisdoms6969
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added a few icons for much faster visual differentiation between the options
By the way, do you know how to force those text icons to be in place of actual icons in the menus (there is a dedicated column for them left of text, this would solve the misalignment issue)?
I'd gone with the tradition of adding accelerators to the matching letters within the name if found, but honestly I'd just move all of them to the left just like for
&D Save selection"since it's (to me) more important to see the shortcut right away, and those tiny underscores in the middle of sentences aren't very functional even if looking nicerAnother downside is that the extension menu has those ugly
&marks not removed in some browsers (not in Chrome, though), and even with them the accelerators seem to work, but that's on browsersI'd also rename the extension to
&SingleFilejust for this :) but that's maybe going too far, will just do it locally (though would be nice to find a way to somehow make it user configurable not to do ugly local patches)(moved items around to match the menu order to make keeping track of the shortcuts/edits easier)
Partially addresses #1420