Skip to content

feat: Add Automatic Folder Sorting, Context Menu Extension, and Resumability Warnings#263

Open
deepthumar81 wants to merge 5 commits into
giantpinkrobots:nextfrom
deepthumar81:next
Open

feat: Add Automatic Folder Sorting, Context Menu Extension, and Resumability Warnings#263
deepthumar81 wants to merge 5 commits into
giantpinkrobots:nextfrom
deepthumar81:next

Conversation

@deepthumar81

Copy link
Copy Markdown

This Pull Request introduces three major feature enhancements to Varia:

1. Automatic Folder Sorting (by file category)

  • Automatically categorizes and routes downloaded files into subdirectories under the user-configured download directory.
  • Supports 5 main categories:
    • Compressed (.zip, .rar, .7z, etc.)
    • Pictures (.jpg, .png, .gif, etc.)
    • Documents (.pdf, .docx, .txt, etc.)
    • Video (.mp4, .mkv, etc. including video playlists)
    • Music (.mp3, .wav, etc.)
  • A toggle switch has been added to Preferences (disabled by default) to turn this feature on or off.
  • Automatically handles moving of completed downloads added via the browser extension, folder/file collisions, and preserves torrent downloads without sorting to prevent seeding issues.

2. Browser Extension Context Menu

  • Adds a "Download with Varia" option to the browser right-click context menu (for links, images, videos, and audio).
  • Allows direct link routing to Varia's JSON-RPC endpoint (6801) without relying solely on automatic interception.

3. Resumability Visual Indicators & Safety Warnings

  • Performs an asynchronous range check at initiation to verify if the file URL supports resuming.
  • Adds visual indicators directly on the download row for files that do not support resuming:
    • Red ⚠️ No Resume badge next to the percentage indicator.
    • Suffixes · Non-Resumable to the speed/ETA status label.
  • Adds confirmation dialogs (Adw.AlertDialog) warning the user of potential progress loss before pausing:
    • Intercepts the action row's pause button.
    • Intercepts the global "Pause All" toolbar button if any running download is non-resumable.

@giantpinkrobots

Copy link
Copy Markdown
Owner

You don't think three new features is a tad excessive? I'm not against the use of AI in contributions, but not at this scale. This is a large amount of code to review at once, and you bundling all these features into one PR makes is difficult to discuss these implementations.

These are all good ideas, and I'd like them all implemented. But I have issues with some of these implementations. For instance, I think there's probably a more elegant way to make the user know their downloads may not be able to be resumed if paused, other than adding more text and emojis next to the percentage. I also feel like a three second timeout period for determining resumability is probably excessive and may lead to false positives. At the end of the day it's never guaranteed that a download may be resumed.

The browser extension fix seems good, can be implemented as-is. But I can't merge all of these at once.

@deepthumar81

deepthumar81 commented Jun 20, 2026

Copy link
Copy Markdown
Author

You don't think three new features is a tad excessive? I'm not against the use of AI in contributions, but not at this scale. This is a large amount of code to review at once, and you bundling all these features into one PR makes is difficult to discuss these implementations.

These are all good ideas, and I'd like them all implemented. But I have issues with some of these implementations. For instance, I think there's probably a more elegant way to make the user know their downloads may not be able to be resumed if paused, other than adding more text and emojis next to the percentage. I also feel like a three second timeout period for determining resumability is probably excessive and may lead to false positives. At the end of the day it's never guaranteed that a download may be resumed.

The browser extension fix seems good, can be implemented as-is. But I can't merge all of these at once.

Thank you for your thoughtful feedback on the pull request. I appreciate the concern regarding the scale of the features included in this PR. I am not a developer in this domain. I mostly work in the machine learning domain. But recently I faced some issue in the old download manager named "XDM" which has not been maintained for a long time so there are compatibility issues with new browsers.

I got a recommendation for this Varia app which is new and compatible with the most modern browser and wide range of OS. While using this I found that this lack some features which are key features for a tool like this as per my usage like (folder shorting, resume indication and browser automatic file capture). So I take help from ai to implement this idea; i know using ai for code blindly is risky and may lead to security concerns for the end user.

Still I am happy that you like the ideas and it's okay if you skip this implementation. And I am open for any help I can do for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants