vscodium: fix symbolic linking issue with executable#9302
Conversation
**Summary** Currently, the symlink between the executable and the bin file to run it isn't working. It silently fails to create the symlink. This PR fixes the issue.
| %workdir%/src/stable/resources/linux/code.desktop | ||
|
|
||
| # replace executable and remaining icon placeholders | ||
| sed -i -e 's|@@EXEC@@|codium|g' -e 's|@@ICON@@|vscodium|g' %workdir%/src/stable/resources/linux/code.desktop |
There was a problem hiding this comment.
Could this last sed be avoided by doing the desktop-file-edit after building/installing?
There was a problem hiding this comment.
From what I can tell, upstream fills in the values only for like snaps and deb builds for linux here: https://github.com/microsoft/vscode/blob/main/build/gulpfile.vscode.linux.ts
So the replacement needs to be done manually. The reason I had to use sed was because desktop-file-edit only touches stuff in the [Desktop Entry] section, not the [Desktop Action ... ] section, which left icon and exec in that area untouched.
https://github.com/VSCodium/vscodium/blob/master/src/stable/resources/linux/code.desktop
I think a cleaner approach might be to create a patch or recreate the .desktop file and throw it in with the files.
Summary
Currently, the symlink between the executable and the bin file to run it isn't working. It silently fails to create the symlink. Chatted in matrix and found a solution, which this implements. Also, this adjusted the value of mime type to match flatpak version just in case it causes an issue with some part of the app I did not test that expects it.
Test Plan
Checklist