difftastic: Initial packaging.#9201
Conversation
**Summary**
|
This looks like a nice tool, but I don't see a package request for it. Please submit one. This helps us document why packages are added. For now I will mark this PR as a draft |
|
okay thanks @davidjharder I did not realise a request was needed, I have created one here #9221 I created this for myself but created the PR in case it was wanted as I went to the effort of packaging it. |
| build : | | ||
| %cargo_build | ||
| install : | | ||
| install -Dm0755 $workdir/target/release/difft $installdir/usr/bin/difft |
There was a problem hiding this comment.
Please use the %cargo_install macro if it works here
There was a problem hiding this comment.
I did try this initially it failed, is there a way to see what these macros are actually doing ?
There was a problem hiding this comment.
Aside from error messages you can see the macro definitions here: https://github.com/getsolus/ypkg/blob/85340f6035c9ff516d749b078cd2d81c4e1c7d36/data/macros/actions/cargo.yaml
There was a problem hiding this comment.
%cargo_install difft works for me
|
Sorry for my two cents but this also needs a monitoring.yaml. |
**Summary**
|
Also squash the commits into one commit. This is a good resource to use to figure out git. Also look at some of the pending PR's or accepted new package PR's to see our flow. |
Summary
Alternative diff tool which can do structural diffs
Resolves #9221
Test Plan
Generated package installed in unstable vm and ran difft to check the command executed and returned the help
Checklist