Add a first-class expoRouterIntegration() with auto-registration (#6156)#6189
Open
alwx wants to merge 4 commits into
Open
Add a first-class expoRouterIntegration() with auto-registration (#6156)#6189alwx wants to merge 4 commits into
alwx wants to merge 4 commits into
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
Plus 13 more 🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 25475dc. Configure here.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
antonis
reviewed
May 19, 2026
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Other than the lint issues that should be fixable with yarn fix and the agent comments LGTM
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+142
to
+144
| if (hasTracingEnabled && options.enableAutoPerformanceTracing) { | ||
| integrations.push(expoRouterIntegration()); | ||
| } |
There was a problem hiding this comment.
Bug: User-provided options for expoRouterIntegration are ignored because a default instance is auto-registered first, preventing the user's configuration from being applied.
Severity: MEDIUM
Suggested Fix
Modify the integration setup logic to ensure that if a user-configured expoRouterIntegration exists, the default one is not added. Alternatively, merge the options from the user-provided instance into the existing one if it's already been created.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/core/src/js/integrations/default.ts#L142-L144
Potential issue: When tracing is enabled, `expoRouterIntegration()` is automatically
registered without options. If a user also manually provides `expoRouterIntegration`
with options (e.g., `enableTimeToInitialDisplay: true`), the final integration array
contains two instances. The first, default instance creates a
`reactNavigationIntegration`. The second, user-configured instance finds this existing
integration and reuses it, but fails to apply the user-provided options. As a result,
any options specified by the user for `expoRouterIntegration` are silently ignored.
Also affects:
samples/expo/app/_layout.tsx
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
There was a problem hiding this comment.
I think the above is not an issue
antonis
reviewed
May 20, 2026
| // Warning: (ae-forgotten-export) The symbol "ExpoRouterIntegrationOptions" needs to be exported by the entry point index.d.ts | ||
| // | ||
| // @public | ||
| export const expoRouterIntegration: (options?: Partial<ExpoRouterIntegrationOptions>) => Integration; |
Contributor
There was a problem hiding this comment.
This would need to change after the latest fixes
Suggested change
| export const expoRouterIntegration: (options?: Partial<ExpoRouterIntegrationOptions>) => Integration; | |
| export const expoRouterIntegration: (options?: ExpoRouterIntegrationOptions) => Integration; |
antonis
reviewed
May 20, 2026
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Other than the api change issue LGMT!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes #6156
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
Docs need to be updated as well