build: download ACKNOWLEDGEMENTS.md for sentry-cli when packing #5231
+15
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,14 +116,28 @@ | |
| <SentryCLIDownload Condition="'$(CI_PUBLISHING_BUILD)' == 'true' Or ($([MSBuild]::IsOSPlatform('Windows')) And $(_OSArchitecture) != 'X86')" Include="sentry-cli-Windows-x86_64.exe" FileHash="572b4a6c04504302a46e2e1c196ec31cda266b574b1444605426aa8e41d46b8c" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Download the platform-specific CLI binaries. --> | ||
| <DownloadFile SourceUrl="https://downloads.sentry-cdn.com/sentry-cli/$(SentryCLIVersion)/%(SentryCLIDownload.Identity)" DestinationFolder="$(SentryCLIDirectory)" Condition="!Exists('$(SentryCLIDirectory)%(Identity)')" Retries="3"> | ||
| <Output TaskParameter="DownloadedFile" ItemName="SentryCLIDownloadedFile" /> | ||
| </DownloadFile> | ||
|
|
||
| <!-- Build will fail if any downloaded files don't match the expected hash. --> | ||
| <VerifyFileHash File="$(SentryCLIDirectory)%(SentryCLIDownload.Identity)" Hash="%(FileHash)" /> | ||
|
|
||
| <!-- | ||
| Download the platform-independent ACKNOWLEDGEMENTS.md that lists third-party OSS | ||
| attributions compiled into the sentry-cli binary. Required for license compliance | ||
| when redistributing the CLI executables in the Sentry NuGet package. | ||
| ContinueOnError is temporary while getsentry/sentry-cli#2823 is in progress — | ||
| remove it once sentry-cli starts publishing this file in releases. | ||
| --> | ||
| <DownloadFile | ||
| SourceUrl="https://downloads.sentry-cdn.com/sentry-cli/$(SentryCLIVersion)/ACKNOWLEDGEMENTS.md" | ||
|
Flash0ver marked this conversation as resolved.
|
||
| DestinationFolder="$(SentryCLIDirectory)" | ||
| Condition="!Exists('$(SentryCLIDirectory)ACKNOWLEDGEMENTS.md')" | ||
| ContinueOnError="WarnAndContinue" | ||
|
Member
There was a problem hiding this comment. question: should we do this now? Since getsentry/sentry-cli#2823 is not complete yet, this will always fail.
Collaborator
Author
There was a problem hiding this comment. Yeah I've marked the issue this closes as blocked by 2823. |
||
| Retries="3" /> | ||
|
|
||
| <!-- Set executable permissions for local usage. --> | ||
| <Exec Command="chmod +x $(SentryCLIDirectory)*" Condition="!$([MSBuild]::IsOSPlatform('Windows'))" /> | ||
| </Target> | ||
|
Comment on lines
+139
to
143
Member
There was a problem hiding this comment. question: make Already existing code ... but would we make the |
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: multi-targeting
Is this task executed multiple times, do to multiple
TargetFrameworks?If so - can we easily ensure to only run once?