fix(spans): Do dynamic sampling after normalization#6121
Closed
loewenheim wants to merge 3 commits into
Closed
Conversation
Follow-up to #6042. Doing dynamic sampling before normalization means that the `is_segment` flag on produced metrics can vary depending on whether the span is sampled or not. Therefore, we now do dynamic sampling after normalization.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a3bf136. Configure here.
jjbayer
reviewed
Jun 23, 2026
Dav1dde
approved these changes
Jun 23, 2026
Contributor
Author
|
#6126 sidesteps the entire problem by modifying the |
auto-merge was automatically disabled
June 23, 2026 12:42
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6042. Doing dynamic sampling before normalization means that the
is_segmentflag on produced metrics can vary depending on whether the span is sampled or not. Therefore, we now do dynamic sampling after normalization.