fix: use first tool version from .tool-versions when multiple are declared#1147
Open
marnagy wants to merge 15 commits into
Open
fix: use first tool version from .tool-versions when multiple are declared#1147marnagy wants to merge 15 commits into
marnagy wants to merge 15 commits into
Conversation
Contributor
|
The issue is ready for review, and the acceptance criteria have been met:
|
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
Contributor
|
Link to code coverage report (posted by coverbot 🤖) |
malept
requested changes
May 18, 2026
Member
There was a problem hiding this comment.
The design of this change is approaching the problem from the wrong angle. Try this instead:
[REMOVED, see later comment]
Also, this fix is missing tests (originally for version_all_from_toolversions but for the suggestion, versions_from_toolversions).
malept
requested changes
May 18, 2026
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
That being said, I think the simpler solution is to just install the first Node.js version and ignore the rest. Still needs regression tests though.
…ests - Use version_from_toolversions (first entry) instead of iterating all versions with version_all_from_toolversions in both shell/ci/env/mise.sh and shell/circleci/machine.sh, as requested by reviewer - Add shell/lib/mise_test.bats with regression tests for version_from_toolversions and version_all_from_toolversions
malept
requested changes
May 18, 2026
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
Remove version_all_from_toolversions, it's unused
malept
requested changes
May 19, 2026
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
- Revert changes in
shell/ci/env/mise.shandshell/circleci/machine.sh, it's not worth changing the order. - Fix function comment for
version_from_toolversions- it's referencing a now-deleted function and the actual change can be better integrated into the doc comment, rather than appending a note at the end. - Add regression tests for
version_from_toolversions.
Member
|
Also probably needs a better PR title |
marnagy
changed the title
malept
changed the title
malept
requested changes
May 20, 2026
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
What is says on the tin.
Jira ID
DT-5340
Notes for your reviewers
Rovo Dev code review: Rovo Dev has reviewed this pull request
Any suggestions or improvements have been posted as pull request comments.