Fix critical OAuth MCP foundation issues - #393
Merged
Merged
Conversation
prvnsmpth
force-pushed
the
fix/pr-377-critical-review-fixes
branch
from
July 30, 2026 09:57
52ef9dd to
c706575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #377. Merge this immediately after #377; until then GitHub will show the foundation commits in this PR as well.
The intentionally deferred cross-SDK action-scope metadata abstraction is not addressed here.
Validation
cargo check -p omni-connector-manager -p omni-google-connector -p omni-connector-sdkcargo test -p shared oauth_refresh_testscargo test -p omni-indexer test_completed_sync_is_ready_below_batch_thresholdcd sdk/typescript && npm test(86 tests)cd sdk/typescript && npm run buildpython3 -m compileall; the AI test environment dependencies are not installed locally