Skip to content

[fix: chart/table data] resolve data unavailable when chart/table changes on live stories#1217

Open
socallmebertille wants to merge 4 commits into
mainfrom
fix/869-story-charts-render-unavailable-v2
Open

[fix: chart/table data] resolve data unavailable when chart/table changes on live stories#1217
socallmebertille wants to merge 4 commits into
mainfrom
fix/869-story-charts-render-unavailable-v2

Conversation

@socallmebertille

@socallmebertille socallmebertille commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Live stories showed "chart/table data unavailable" after editing a chart, because the story kept serving its old cached data which no longer matched the edited chart.

=> This fix fills in the missing data from the chat's existing query results, so edited charts and tables render right away in view mode without needing to refresh or re-save.

Related issue

#869

Review in cubic

@socallmebertille socallmebertille self-assigned this Jul 20, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/backend/src/trpc/story.routes.ts
Comment thread apps/backend/src/services/live-story.ts Outdated
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

URL https://pr-1217-dabc452.preview.getnao.io
Commit dabc452

⚠️ No LLM API keys configured - you'll see the API key setup flow when trying to chat.


Preview will be automatically removed when this PR is closed.

@Bl3f Bl3f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, I'm not sure about the naming and the backfill function

Comment thread apps/backend/src/services/live-story.ts Outdated
Comment thread apps/backend/src/services/live-story.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants