fix(engine): plan errors fail fast; service caps consecutive failures#201
Open
gmoigneu wants to merge 1 commit into
Open
fix(engine): plan errors fail fast; service caps consecutive failures#201gmoigneu wants to merge 1 commit into
gmoigneu wants to merge 1 commit into
Conversation
Two related orchestration safety nets called out in #134. 1. cmd/sync.go now checks plan.HasErrors after Plan and before RunOnce. If the plan already knows e.g. "unsupported VCS type", sync exits with ExitCodeError{Code: 2, Cause: ...} instead of re-discovering the same error per resource inside the apply. 2. engine.RunService now bounds consecutive failures at maxConsecutiveServiceFailures (5). A successful sync resets the counter; transient errors are absorbed. Once the cap is hit, RunService returns the wrapped last error so a process supervisor (systemd, kubelet, …) can intervene. Previously a misconfigured service retried forever, burning CPU and network indefinitely. Closes #134.
Contributor
Author
|
This needs a |
Contributor
|
Use atomic update/remove by skill/MCP but integrate a Commit concept |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134. Two safety nets: (1) sync now checks
plan.HasErrorsbeforeRunOnceand exits 2 if the plan already knows the apply will fail. (2)RunServicecaps consecutive failures at 5 (resets on success) and exits with the last error so a process supervisor can intervene.