Skip to content

fix: desktop login centering, BMS app icon, sign out navigation#19

Merged
iamvirul merged 2 commits into
masterfrom
fix/desktop-signout
Jun 17, 2026
Merged

fix: desktop login centering, BMS app icon, sign out navigation#19
iamvirul merged 2 commits into
masterfrom
fix/desktop-signout

Conversation

@iamvirul

Copy link
Copy Markdown
Member

Summary

Three desktop-specific fixes: login card not vertically centered, Flutter default app icon, and sign out not navigating back to login.

Type

  • Bug fix

Changes

  • Login screen: replaced `Column(spaceBetween)` with `LayoutBuilder + SingleChildScrollView + IntrinsicHeight + Expanded(Center(...))` so the card is always vertically centered on any window size while the footer stays pinned at the bottom
  • macOS app icon: generated all required sizes (16, 32, 64, 128, 256, 512, 1024px) from `bms_logo.svg` using `rsvg-convert`, replacing the default Flutter icon in `AppIcon.appiconset`
  • Router: changed `appRouterProvider` from auto-dispose to `keepAlive: true`, replaced the recreate-on-auth-change anti-pattern with a `_RouterNotifier + refreshListenable` approach - the GoRouter instance is now stable and re-evaluates its redirect when auth changes, which makes sign out correctly navigate to login

Test plan

  • Hot reloaded and tested manually
  • Checked on Chrome (flutter run -d chrome)
  • No regressions in related screens

@iamvirul iamvirul added this pull request to the merge queue Jun 17, 2026
Merged via the queue into master with commit 0a3fbf5 Jun 17, 2026
5 checks passed
@iamvirul iamvirul deleted the fix/desktop-signout branch June 17, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants