Skip to content

Use .__str__ rather than .message to print errors.#24

Open
jorgenpt wants to merge 1 commit into
georgebrock:masterfrom
jorgenpt:better-error-messages
Open

Use .__str__ rather than .message to print errors.#24
jorgenpt wants to merge 1 commit into
georgebrock:masterfrom
jorgenpt:better-error-messages

Conversation

@jorgenpt

@jorgenpt jorgenpt commented May 5, 2015

Copy link
Copy Markdown

This helps because IOError does not assign `message', but str prints
both the path and the error that occurred.

Old behavior:

$ bin/1pass foo
1pass: Error: 

New behavior:

$ bin/1pass foo               
1pass: Error: [Errno 2] No such file or directory: '/home/jorgen/Dropbox/1Password.agilekeychain/data/default/encryptionKeys.js'

This helps because IOError does not assign `message', but __str__ prints
both the path and the error that occurred.

This should address georgebrock#7.
@jorgenpt jorgenpt force-pushed the better-error-messages branch from 621f56e to 49d7d8b Compare May 5, 2015 23:25
@jorgenpt

jorgenpt commented May 5, 2015

Copy link
Copy Markdown
Author

Fixes issue #7.

@AlJohri

AlJohri commented Jun 17, 2017

Copy link
Copy Markdown

@AdamIsrael LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants