fix(confluence): respect --ignore-relative-link-errors flag#23
Merged
Conversation
_validate_relative_links was copied from mdfluence but never checked the ignore_relative_link_errors CLI flag. Now validation still runs and logs errors, but only aborts when the flag is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_relative_linkswas copied from mdfluence but never checked the--ignore-relative-link-errorsCLI flag. The flag existed in the CLI argument parser but was never wired up.Changes
ignore_relative_link_errorsfromargsinto_validate_relative_linksSystemExitonly raised when the flag is not setTests performed