Remove const generic from coord buffers#845
Merged
Merged
Conversation
kylebarron
marked this pull request as ready for review
November 14, 2024 22:32
kylebarron
changed the title
kylebarron
enabled auto-merge (squash)
November 14, 2024 23:53
kylebarron
added a commit
that referenced
this pull request
Nov 16, 2024
kylebarron
added a commit
to datafusion-contrib/geodatafusion
that referenced
this pull request
Sep 10, 2025
Removes the `const D: usize` generic on each array type, delegating the coordinate dimension to the coordinate buffer. Closes geoarrow/geoarrow-rs#822, for geoarrow/geoarrow-rs#801. Builds on geoarrow/geoarrow-rs#845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In discussion with Dewey around this PR #844, I realized that regardless of whether we remove the underlying
CoordBufferenum, we can remove the const generic on the CoordBuffer to determine its physical dimension. Even if this is slightly slower, I think it's very important for maintainability.I realize now that this is what b4l was trying to argue for in #822, but I couldn't see what he meant there without an example.
For #822, for #801