Skip to content

Switch to pnpm#149

Merged
schtibe merged 2 commits into
masterfrom
feat-incident-clickable
May 18, 2026
Merged

Switch to pnpm#149
schtibe merged 2 commits into
masterfrom
feat-incident-clickable

Conversation

@schtibe
Copy link
Copy Markdown
Contributor

@schtibe schtibe commented May 11, 2026

With all the other frontend projects we're using pnpm instead of npm these days. I suggest switching here, too!
WDYT?

It should not be much more than just typing pnpm instead of npm in the CLI.
Also, I needed to add the package 'shiki' in my case, it seemed to be missing (but maybe that's because pnpm behaves slightly different?)

If you're OK with this, I will have to update the codebuild project to use pnpm as well before we can merge this

Test link

@pedroslvieira
Copy link
Copy Markdown
Contributor

Hey @schtibe, thanks for the update. Since it's a small project with very few dependencies, I don't see other reason to implement it other than keeping it consistent with other projects. If you're familiar with it, I'm not against it.

The 'shiki' package problem is probably because it's a dependency of vite-press, with npm we can directly use it but with pnpm we need to add to the packages. Can you do that please?

Copy link
Copy Markdown
Contributor

@asteiner-swisstopo asteiner-swisstopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to judge for me what is better but I like consistency - so go for it 👍

And yes, don't forget to make a corresponding change in CodeBuild..

@schtibe
Copy link
Copy Markdown
Contributor Author

schtibe commented May 18, 2026

Hey @schtibe, thanks for the update. Since it's a small project with very few dependencies, I don't see other reason to implement it other than keeping it consistent with other projects. If you're familiar with it, I'm not against it.

Yes it's really only to be consistent with the rest! Otherwise you're right, there's not much to be gained in this project.

The 'shiki' package problem is probably because it's a dependency of vite-press, with npm we can directly use it but with pnpm we need to add to the packages. Can you do that please?

Yes I'm gonna do that. I did it locally, but first wanted to know you guy's opinion!

@schtibe schtibe force-pushed the feat-incident-clickable branch from 8509371 to 70e7b43 Compare May 18, 2026 09:39
@schtibe schtibe merged commit 6a5f2bc into master May 18, 2026
2 checks passed
@schtibe schtibe deleted the feat-incident-clickable branch May 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants