Switch to pnpm#149
Conversation
|
Hey @schtibe, thanks for the update. Since it's a small project with very few dependencies, I don't see other reason to implement it other than keeping it consistent with other projects. If you're familiar with it, I'm not against it. The 'shiki' package problem is probably because it's a dependency of vite-press, with npm we can directly use it but with pnpm we need to add to the packages. Can you do that please? |
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
Hard to judge for me what is better but I like consistency - so go for it 👍
And yes, don't forget to make a corresponding change in CodeBuild..
Yes it's really only to be consistent with the rest! Otherwise you're right, there's not much to be gained in this project.
Yes I'm gonna do that. I did it locally, but first wanted to know you guy's opinion! |
8509371 to
70e7b43
Compare
With all the other frontend projects we're using pnpm instead of npm these days. I suggest switching here, too!
WDYT?
It should not be much more than just typing
pnpminstead ofnpmin the CLI.Also, I needed to add the package 'shiki' in my case, it seemed to be missing (but maybe that's because pnpm behaves slightly different?)
If you're OK with this, I will have to update the codebuild project to use
pnpmas well before we can merge thisTest link