download_weights: Use destination for tempdir - #139
Open
sgallagher wants to merge 1 commit into
Open
Conversation
There is no guarantee that the default tempfile location (usually /tmp) will have sufficient space to contain the downloaded model files before they are moved into their final location. Use the output_dir location to hold the temporary files, which will ensure that only the destination directory's space (or lack thereof) applies when checking for availability. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no guarantee that the default tempfile location (usually
/tmp) will have sufficient space to contain the downloaded model files before they are moved into their final location. Use theoutput_dirlocation to hold the temporary files, which will ensure that only the destination directory's space (or lack thereof) applies when checking for availability.