fix: 404 errors from celestial.js on page load#57
Open
eatyourgreens wants to merge 1 commit into
Open
Conversation
Fix the missing data files error popup for the ATLAS sky map by adding the `data/` directory to `celestial.js`. Constellations and the Milky Way are shown by default, but can be turned off in the configuration script.
Owner
|
Can we hold off on this one please. I'm not sure what triggered the fix here. Which issue is this related to? The files changed are deep inside the |
Collaborator
Author
|
@genghisken this is a fix for the error popup that Celestial shows, because its data files are missing.
I copied the JSON files over from https://github.com/ofrohn/d3-celestial |
Collaborator
Author
|
Looking at the code, only psat-server-web/psat_server_web/atlas/site_media/js/celestial/celestial.js Lines 149 to 154 in b6c6a3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix the missing data files error popup for the ATLAS sky map by adding the
data/directory tocelestial.js.Constellations and the Milky Way are shown by default, but can be turned off in the configuration script.