fix: stream audio for Consolidate by Character export in stream-only …#1061
Conversation
…mode Consolidate by Character only checked for local files (pathExists), so in stream-only mode every clip was dropped and the export wrote 0 files. Reuse the per-cell exporter's LFS streaming path: extract resolveAudioBytes and a shared setupAudioStreaming helper from audioExporter, then resolve each unique clip source (downloading LFS objects with retry + the shared cache) into temp files for FFmpeg. Also honor selectedMilestonesByFile, support cancellation, and surface a clear error instead of a silent "0 files written".
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
Instead of having the toast with the progress when preparing the content, it should follow the same pattern of having the Download box show what is happening. The toast stops after the content is prepared, but I don't know how the other processes are moving. If I cancel, it does stop everything, but it should show me at which point I am cancelling.
Basically, make it work like it does for the other audio formats.
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
This also is not working: Download retry/backoff works on transient network failure.
Need to go though the test checklist on the main ticket to make sure those points are still working.
Route progress, errors, completion, and cancellation through the shared ExportProgressReporter so Consolidate by Character renders in the same stage-based download box as Include Audio (and the cancel state is visible). Replaces the prior withProgress notification + toast pattern.
…aracter-only-work-in-auto-download-mode
|
I think all of this is fixed... and I did an odious amount of testing to make sure. Haven't yet tested multi-milestone consolidation (didn't have a file for it, but I could go figure out how to make a vtt for this) or when frontier unavailable (It was still working somehow when I was signed out). But other than these it seems pretty solid. |
…aracter-only-work-in-auto-download-mode
…aracter-only-work-in-auto-download-mode
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
Works well now. If a character is not in the milestone section that is chosen and doesn't have any other speaking parts in the chosen milestone, it will not write out their file.
LeviXIII
deleted the
1060-bug-audio-exports-for-consolidate-by-character-only-work-in-auto-download-mode
branch
2 participants
PR Title
1060-Audio Exports for Consolidate by Character only works in auto-download mode
Summary
Closes #1060
Makes Consolidate-by-Character exporting work with all stream/download modes.
Claude: "Consolidate by Character now resolves audio via the same LFS streaming path as Include Audio, so export works in stream-only/stream-and-save (not just auto-download)."
Changes
setupAudioStreaming+ exportedresolveAudioBytesfromaudioExporter.tsselectedMilestonesByFile; supports cancellationTesting Checklist
Consolidate by Character
.wavper character label; clips DAW-align from 0:00Regression
.wavoutput)Screenshots
N/A