Fix .npmrc min-release-age: value is days, not seconds#437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min-release-ageis interpreted by npm as a number of days, not seconds.npm's own config flattener (
@npmcli/config) computes the cutoff as:86400000ms = one day, so the value is multiplied by days.604800→ 604800 days (~1656 years) → cutoff lands in year 370 AD → npm rejectsevery package version (
ENOVERSIONS/ETARGET), breaking all installs.7d→ invalid (config type isNumber, not a string) → parsed asnull→ thecooldown is silently disabled (no protection at all).
7→ 7 days → correct.This restores the intended 7-day supply-chain quarantine. Verified against npm
11.14.1:
7blocks releases <7 days old and allows older ones.🤖 Generated with Claude Code