Migrate Android icons to Material Symbols#387
Merged
Conversation
Wrap the action button icon in a Box so the circle background and the icon glyph have independent sizes, matching the iOS RoundButton layout: - Circle: 48dp (was 54dp), matches iOS 48pt - Glyph: 24dp explicit size (was 22dp implicit via padding) Replaces the requiredSize + padding trick that conflated the circle and glyph sizing.
Collaborator
Author
|
Find the best icons for Android |
Google deprecated androidx.compose.material:material-icons-core/extended and recommends Material Symbols XML drawables instead [1]. Replace all 51 deprecated Icons.* usages across 74 files with Material Symbols Rounded drawables in res/drawable/ and drop the deprecated dependency. Add AppIcons registry (icons/AppIcons.kt) so call sites stay clean (Icons.Filled.X → AppIcons.X), mirroring the iOS Images.System.* pattern for cross-platform parity. Action buttons (Send/Receive/Buy/Swap) use FILL=0 (outlined) to match iOS SF Symbols which use the plain (non-.fill) variants on the asset scene. Deposit/Withdraw keep FILL=1 since iOS uses filled custom SVG assets there. Glyph size bumped from 24dp to 28dp to compensate for Material Symbols' internal padding and visually match iOS proportions. [1] https://developer.android.com/develop/ui/compose/graphics/images/material
gemdev111
approved these changes
May 28, 2026
…on-button-ios-parity
ChartStateView was added on main after this branch diverged, so the icon migration script didn't touch it. Switch Icons.Outlined.Warning to AppIcons.Warning to unblock CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339
Summary
Migrate Android icons from the deprecated
material-icons-extendedto Material Symbols Rounded, per Google's official recommendation.Adds an
AppIconsregistry — call sites useAppIcons.Xinstead ofIcons.Filled.X. Action buttons match iOS visually (outlined Send/Receive/Buy/Swap, filled Deposit/Withdraw, 28dp glyph in 48dp circle).