[codex] Remove legacy device authentication#1156
Draft
gemcoder21 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes legacy device authentication mechanisms, including individual x-device-* and x-wallet-id headers, in favor of a single unified Authorization: Gem ... header. It cleans up the authentication logic across the API, simplifies signature verification, removes the legacy fallback code, and updates the corresponding documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-device-*andx-wallet-idrequest authentication headersAuthorization: Gem ...payload wallet idValidation
just formatcargo clippy -p gem_auth -- -D warningscargo clippy -p storage -- -D warningscargo clippy -p api -- -D warningsjust test storagejust test gem_authjust test api