Skip to content

Endpoint to create new mappings#13

Merged
Hendrejvr merged 8 commits into
mainfrom
feature/create-new-mapping-endpoint
Nov 24, 2025
Merged

Endpoint to create new mappings#13
Hendrejvr merged 8 commits into
mainfrom
feature/create-new-mapping-endpoint

Conversation

@Hendrejvr

Copy link
Copy Markdown
Contributor

A new endpoint has been added allowing the creation of new mappings via the API.

The endpoint requires a project_key and MappingBase object

@Hendrejvr Hendrejvr self-assigned this Aug 8, 2025
@Hendrejvr Hendrejvr marked this pull request as ready for review August 12, 2025 13:50
@Hendrejvr

Copy link
Copy Markdown
Contributor Author

@nikohl-de Ich habe den Endpnkt als POST "/project/{project_key}/mapping" definiert. Ich kann ihn gerne wieder ändern, falls ihr das möchtet

@Hendrejvr Hendrejvr linked an issue Aug 12, 2025 that may be closed by this pull request
@nikohl-de

Copy link
Copy Markdown
Contributor

@nikohl-de Ich habe den Endpnkt als POST "/project/{project_key}/mapping" definiert. Ich kann ihn gerne wieder ändern, falls ihr das möchtet

@Hendrejvr Von meiner Seite aus passt der Endpunkt so sehr gut :)

@cybernop cybernop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you have a look at the few comments and maybe check if you could clean-up some commented-out code that is not needed?

Comment thread service/src/structure_comparer/data/mapping.py
Comment thread service/src/structure_comparer/data/profile.py Outdated
Comment thread service/src/structure_comparer/handler/mapping.py Outdated
Comment thread service/src/structure_comparer/handler/mapping.py Outdated

@cybernop cybernop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the remaining comments

Comment thread service/src/structure_comparer/data/mapping.py
Comment thread service/src/structure_comparer/handler/mapping.py Outdated
@Hendrejvr Hendrejvr requested a review from cybernop October 17, 2025 13:22
@Hendrejvr Hendrejvr merged commit 938fff5 into main Nov 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endpoint to create new mapping

3 participants