Fix for Issue 10 in ep_tables - #16
Open
DanBeard wants to merge 1 commit into
Open
Conversation
In some cases (like when looking at the time slider) it turns out what etherpad says is a node, actually is just a normal javascript object with innerhtml defined. Trying to call DOM functions on this node will reveal it for the phony that it is, and it will throw an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #10
In some cases (like when looking at the time slider) it turns out what etherpad says is a node, actually is just a normal javascript object with innerhtml defined.
Trying to call DOM functions on this node will reveal it for the phony that it is, and it will throw an exception.
This fix disables the tables functionality in the timeslider perspective, but at least it's still usable.
I couldn't find an elegant cross-browser solution to checking if an object was really a DOM node or not, so I just check to see if it has a tagName. DOM nodes do, and fake dictionaries don't .
We should start a discussion over at etherpad, they should update their documentation with a warning that acePostWriteDomLineHTML might not always be given an actual DOM node.