Add file validation#2
Merged
Merged
Conversation
Add comprehensive file validation to prevent malicious file uploads: - Implement magic byte (file signature) validation for all supported file types - Validate file extensions match declared content types - Support all image formats: PNG, JPEG, WebP, SVG, TIFF - Support all video formats: MP4, MPEG, OGG - Support document formats: PDF, TXT - Integrate validation into upload controller before processing - Add comprehensive test suite with 40+ test cases Security improvements: - Prevent upload of files with fake extensions (e.g., malware.jpg that's actually .exe) - Verify actual file content matches Content-Type header - Detect tampered or corrupted file headers - Early rejection of invalid files before AWS upload The validator checks magic bytes at correct offsets: - Images: PNG (8 bytes), JPEG (4 bytes), WebP (RIFF+WEBP), TIFF (4 bytes) - Videos: MP4 (offset 4), MPEG (4 bytes), OGG (4 bytes) - Documents: PDF (%PDF marker) - SVG: XML-based validation Closes security gap identified in code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.