Skip to content

feat(parser): replace ParseStandard() with StandardOptions#53

Merged
janrnc merged 2 commits into
gdgvda:masterfrom
janrnc:feat/remove-parse-standard
Apr 27, 2026
Merged

feat(parser): replace ParseStandard() with StandardOptions#53
janrnc merged 2 commits into
gdgvda:masterfrom
janrnc:feat/remove-parse-standard

Conversation

@janrnc

@janrnc janrnc commented Apr 26, 2026

Copy link
Copy Markdown
Member
  • Removed the standalone ParseStandard convenience function and the internal standardParser variable from parser.go.
  • Added a new exported constant StandardOptions that encapsulates the default standard cron parsing options (Minute | Hour | Dom | Month | Dow | Descriptor).
  • Revised doc.go to demonstrate the new recommended pattern: instantiating a default parser using cron.NewDefaultParser(cron.StandardOptions) and calling Parse() on it.
  • Updated test files to initialize their own standard parser instances where needed, replacing the old ParseStandard calls.

@codecov

codecov Bot commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (a84ff6c) to head (c73cc59).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   94.64%   95.14%   +0.50%     
==========================================
  Files          18       18              
  Lines        1083      886     -197     
==========================================
- Hits         1025      843     -182     
+ Misses         45       30      -15     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janrnc janrnc marked this pull request as ready for review April 27, 2026 19:39
@janrnc janrnc merged commit 4365a3b into gdgvda:master Apr 27, 2026
5 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant