feat: remove parser interface and return default structs for parser and schedule#51
Merged
janrnc merged 2 commits intoApr 22, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 95.22% 94.64% -0.59%
==========================================
Files 18 18
Lines 901 1083 +182
==========================================
+ Hits 858 1025 +167
- Misses 30 45 +15
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ser and scheduler
78b7a3e to
bcb7960
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the core API to improve decoupling between schedule parsing and job execution by replacing the
Parserinterface with concrete structs and restructuring the schedule-related code.Changes
cron.Add(spec, cmd)method; require all jobs usecron.Schedule(schedule, cmd).Parserinterface with concreteDefaultParserstruct.DefaultParserandDefaultScheduleas public types.NewDefaultParserto return(*DefaultParser, error).WithParserandWithSecondsconfiguration options.spec.gotoschedule.goandspec_test.gotoschedule_test.go.Scheduleinterface fromcron.gotoschedule.go.See #49