Replaced tests for InOnlyConcourseResource that reached out to the internet#42
Merged
Merged
Conversation
…that doesn't reach out to the internet
tm91236
reviewed
Apr 15, 2026
tm91236
left a comment
tm91236
left a comment
Member
There was a problem hiding this comment.
Small comment, otherwise LGTM.
… the test BUILD_NAME is as we expect in the debugging output
|
tm91236
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces a test for the
InOnlyConcourseResourcewhich involved a mock resource downloading a file from the GCHQ website. This file moved, which prompted a rewrite of the test anyway, but attempting to safely download this file without additional dependencies in a way which worked widely across all dev environments was a little out of scope for this project.The mock resource now just writes a file to disk, since the tests are only really to check that the correct internal functions have been called by the standard API. I've also added some extra lines to improve coverage for the admittedly trivial) implementations of
InOnlyConcourseResource.fetch_new_versionsandInOnlyConcourseResource.publish_new_version.