Skip to content

helper types for viewing/modifying beacon state deltas + decompose#50

Merged
ninaiiad merged 8 commits into
mainfrom
ng/delta-view
May 27, 2026
Merged

helper types for viewing/modifying beacon state deltas + decompose#50
ninaiiad merged 8 commits into
mainfrom
ng/delta-view

Conversation

@ninaiiad
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread crates/common/src/beacon_state/delta_view.rs Outdated
Comment thread crates/common/src/beacon_state/delta_view.rs
Comment thread crates/common/src/beacon_state/delta_view.rs
Copy link
Copy Markdown
Collaborator

@vladimir-ea vladimir-ea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - only question I have is on integration with BeaconStateOwner and BeaconStateReader. Note that for the sharing of the state to work, then the finalised state can only be mutated when the sequence lock 'write; state is set like with the WriteGuard in BeaconStateOwner::write()

@ninaiiad ninaiiad force-pushed the ng/delta-view branch 2 times, most recently from 8662733 to da1a7e6 Compare May 26, 2026 16:12
Comment thread crates/common/src/beacon_state/decompose.rs Outdated
Comment thread crates/common/src/beacon_state/decompose.rs
Comment thread crates/common/src/beacon_state/decompose.rs Outdated
Comment thread crates/common/src/beacon_state/validator_identity/finalised.rs Outdated
Comment thread crates/common/src/beacon_state/types.rs
@ninaiiad ninaiiad merged commit 6ac1087 into main May 27, 2026
2 checks passed
@ninaiiad ninaiiad deleted the ng/delta-view branch May 27, 2026 11:12
vladimir-ea pushed a commit that referenced this pull request May 27, 2026
* delta view

* single viewer

* layers

* wire into state views

* fix test

* fixes

* Refactor

* ctor

---------

Co-authored-by: alexX512 <alexey@gattaca.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants