Skip to content

WIP: Patch background map style to remove its housenumbers #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuukka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Patch background map style to remove its housenumbers #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import MapGL, { Popup, Source, Layer, Marker } from "@urbica/react-map-gl";
import { WebMercatorViewport } from "viewport-mercator-project";
import type { WebMercatorViewportOptions } from "viewport-mercator-project";
import { distance as turfDistance } from "@turf/turf";
import { MapboxGeoJSONFeature } from "mapbox-gl";
import { MapboxGeoJSONFeature, Style } from "mapbox-gl";
import "mapbox-gl/dist/mapbox-gl.css";
// eslint-disable-next-line import/no-extraneous-dependencies
import { FeatureCollection } from "geojson";
Expand Down Expand Up @@ -53,6 +53,7 @@ interface State {
popupCoordinates: ElementWithCoordinates | null;
snackbar?: ReactText;
routableTiles: Map<string, FeatureCollection | null>;
basemapStyle: string | Style;
}

const latLngToDestination = (latLng: LatLng): ElementWithCoordinates => ({
Expand Down Expand Up @@ -86,6 +87,16 @@ const initialState: State = {
geolocationPosition: null,
popupCoordinates: null,
routableTiles: new Map(),
basemapStyle: {
layers: [],
sources: {},
version: 8,
// The following are copied from hsl-map-style/simple-style.json
// to avoid the warning "Unable to perform style diff":
glyphs: "https://static.hsldev.com/mapfonts/{fontstack}/{range}.pbf",
sprite:
"https://raw.githubusercontent.com/HSLdevcom/hsl-map-style/master/sprite",
},
};

const metropolitanAreaCenter = [60.17066815612902, 24.941510260105133];
Expand Down Expand Up @@ -195,6 +206,33 @@ const App: React.FC = () => {
);
};

// Download and patch the basemap style
useEffect(() => {
const asyncAction = async (): Promise<void> => {
const response = await fetch(
"https://raw.githubusercontent.com/HSLdevcom/hsl-map-style/master/simple-style.json"
);
const style = (await response.json()) as mapboxgl.Style;
setState((prevState) => ({
...prevState,
basemapStyle: {
...style,
// Hide housenumbers (we draw our own)
layers: style.layers?.filter(
(layer) => layer.id !== "housenum_label"
),
},
}));
};
asyncAction().catch((error) => {
// eslint-disable-next-line no-console
console.error(
"Error while downloading and patching the basemap style:",
error
);
});
}, []);

useEffect(() => {
if (!map.current || !state.viewport.zoom) {
return; // Nothing to do yet
Expand Down Expand Up @@ -644,7 +682,7 @@ const App: React.FC = () => {
// eslint-disable-next-line react/jsx-props-no-spreading
{...state.viewport}
style={{ width: "100%", height: "90%" }}
mapStyle="https://raw.githubusercontent.com/HSLdevcom/hsl-map-style/master/simple-style.json"
mapStyle={state.basemapStyle}
transformRequest={transformRequest}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
onViewportChange={(viewport: any): void => {
Expand Down