Code reformat for less repetition and better reading#2
Open
Flavsditz wants to merge 10 commits into
Open
Conversation
added 10 commits
December 26, 2020 15:22
…ent cases once a valid one was found
…fy that it is the count for a full cycle (lighting and dimming)
…o a function that gets an arrays of delays as input
… can also be their own function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks so much for writing this! It was really useful when I tried implementing it myself.
I did use an ESP32 though and the code was a bit different for me. So to create this merge Request I changed a to make it so it works for Arduino (I haven't tested since I don't have a freed-up Arduino board here atm).
What I did:
The loops were the same with just different delay values so:
With that, all you have to do is call the doCycle function with the parameters and it works the same with less repeated code.
If you can also test it to see if it works on your board or if you have any other questions we can discuss them here :)