Skip to content

Handle input version correctly for publish to package repos workflow#779

Merged
gardener-prow[bot] merged 1 commit into
mainfrom
cleanup-publish-packages-script
Jul 21, 2026
Merged

Handle input version correctly for publish to package repos workflow#779
gardener-prow[bot] merged 1 commit into
mainfrom
cleanup-publish-packages-script

Conversation

@AleksandarSavchev

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind bug

What this PR does / why we need it:
A bug causing release packages to be sent with wrong version to homebrew and chocolatey has been fixed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A bug causing release packages to be sent with wrong version to `homebrew` and `chocolatey` has been fixed.

@AleksandarSavchev
AleksandarSavchev requested a review from a team as a code owner July 21, 2026 12:26
@gardener-prow gardener-prow Bot added kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 21, 2026
@dimityrmirchev

Copy link
Copy Markdown
Member

so #766 is not actually fixing it?

@AleksandarSavchev

Copy link
Copy Markdown
Member Author

Without #766 the workflow breaks and cannot be manually executed.

However it introduced a new bug, where the input that is passed from the release workflow DOES contain the v prefix and would use vv when sending to one of the package repos, ex: https://github.com/gardener/homebrew-tap/actions/runs/29826526045/job/88621012453

I triggered the workflow manually with version v0.27.1 and we got the PR there gardener/homebrew-tap#121

@dimityrmirchev dimityrmirchev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
@gardener-prow

gardener-prow Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimityrmirchev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow

gardener-prow Bot commented Jul 21, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: e46746808aaaca07f0b3eff3ef0ddc0ceb8dbcfb

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026
@gardener-prow
gardener-prow Bot merged commit 54bc7f0 into main Jul 21, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants