Skip to content

[release-v0.24] Fix: restore CommonName in ACME-issued certificates after lego v5 upgrade#745

Merged
gardener-prow[bot] merged 2 commits into
gardener:release-v0.24from
gardener-ci-robot:cherry-pick-744-to-release-v0.24
Jun 12, 2026
Merged

[release-v0.24] Fix: restore CommonName in ACME-issued certificates after lego v5 upgrade#745
gardener-prow[bot] merged 2 commits into
gardener:release-v0.24from
gardener-ci-robot:cherry-pick-744-to-release-v0.24

Conversation

@gardener-ci-robot

@gardener-ci-robot gardener-ci-robot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This is an automated cherry-pick of #744

/assign MartinWeindel

ACME-issued certificates now include the correct Subject Common Name again. The recent lego v5 upgrade had silently dropped the CN from issued certificates, breaking consumers that pin to or parse `Subject.CommonName`. The CN is now populated from `spec.commonName` (or the first DNS name when CN is unset and ≤64 characters).

@gardener-ci-robot gardener-ci-robot mentioned this pull request Jun 12, 2026
Merged
@gardener-prow gardener-prow Bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2026
MartinWeindel
MartinWeindel approved these changes Jun 12, 2026
View reviewed changes

@MartinWeindel MartinWeindel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@gardener-prow

gardener-prow Bot commented Jun 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinWeindel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow

gardener-prow Bot commented Jun 12, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: b3c942bd492f4395871283abadfb21b19d30e0b0

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@gardener-prow gardener-prow Bot merged commit 1d15fd3 into gardener:release-v0.24 Jun 12, 2026
18 checks passed
@federated-github-access federated-github-access Bot mentioned this pull request Jun 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees

@MartinWeindel MartinWeindel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gardener-ci-robot @MartinWeindel