This repository was archived by the owner on Feb 1, 2026. It is now read-only.
test(backend): fix flawed test assertions in Phase 1#372
Merged
Conversation
Fix 5 flawed tests identified in test suite audit (#333): - Browser Manager: Add spy to verify browser launched only once - Page Capturer: Reclassify 404 as valid HTTP status, not error - Task Queue: Add explicit timestamps to ensure deterministic priority ordering - Visual Comparator: Replace vague assertions with explicit threshold tests - Path Traversal: Clarify that both 400/404 indicate successful blocking All tests passing (683 passed, 23 skipped) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions
Bot
added
size/medium
- queue-concurrency.test.ts: Add CountResult interface for SQL query results - storage-concurrency.test.ts: Fix invalid run status values, use proper union type - path-traversal-advanced.test.ts: Add biome-ignore comments for legitimate 'any' usage in test mocks - keyboard-navigation.test.ts: Use generic Component and ComponentMountingOptions types Fixes all 14 Biome lint warnings about noExplicitAny. All tests pass with Node 22.21.1 and 24.12.0. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions
Bot
added
the
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 5 flawed tests identified in test suite audit (#333):
All tests passing (683 passed, 23 skipped)