Removing references to 'override_redirect'#1
Open
nnesse wants to merge 1 commit into
Open
Conversation
In places where this flag is used in code the 'CWOverrideRedirect' mask is not set so the flag won't take effect. If the mask was set then it would create a window with no window decorations which might not be what the reader wants to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'overide_redirect' flag as used doesn't take effect since it's value mask is omitted. I'm not sure what your intent was but it's not discussed in the readme so fixing it by removing references to it seems reasonable.
The flag prevents the window manager from adding decorations which I'm not sure is the most common use case. If you're removing the decorations you probably want make it a fullscreen window and there is another method for that involving window manager hints that seems to be preferred. There is an example of that in SDL and also in my glplatform library.