Add Wichardt 2008 (GEB) to the catalogue#928
Conversation
|
Looks good but the game seems to not have been created on the catalog docs page - I will investigate |
Ah right @d-kad this is intentional as the EFG lacks a description - if you add one it will get picked up by the catalog. @rahulsavani do you think I should throw a warning or error for any games we try to add which lack a description, could be similar to "Make sure the game includes a description, with any citations referencing the bibliography using the :cite:p: |
|
thanks for investigating this @edwardchalstrey1! |
|
@edwardchalstrey1 You didn't ask me, but there's also a touching point with the discussion in #907. Definitely yes to having an extended description as being required for the catalog. Basically, if a game is interesting enough to be in the catalog, it should be possible to write at least something about why it appears in the original source, even if it's just paraphrasing the exposition in the source. This would also apply to "test case" games which we include in the catalog (the thrust of the discussion in #907) - in contrast to ad-hoc games we might build manually with the API in the test suite for super-specific purposes. |
Contributes to #394
Description of the changes
This PR adds
wichardt2008.efgto the catalogue, updates tests and the corresponding files