Fix linter conflict#924
Merged
Merged
Conversation
tturocy
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving files in an IDE (e.g. VSCode/Antigravity) with the Ruff plugin installed and format-on-save enabled, the formatter automatically reformats Python slices that contain complex expressions (e.g., changing
rst[src_idx:src_idx + 40]torst[src_idx : src_idx + 40]). This is intentional behavior by modern formatters (like Black and Ruff) to improve readability and complies with PEP 8.However, the pre-commit hooks for both
ruffandflake8enforce thepycodestyleruleE203(whitespace before ':'), which strictly disallows this spacing. As a result, files formatted correctly by the IDE were being rejected by the pre-commit linters, blocking commits. This could be an annoying blocker other developers may face.Description of the changes in this PR
This PR adds
E203to the ignore list for both linters:pyproject.tomlto ignoreE203in[tool.ruff.lint]..flake8to includeextend-ignore = E203.How to review this PR
Decide if this is something we need.