Skip to content

Load OpenSpiel games via Gambit Catalog#917

Merged
tturocy merged 13 commits into
masterfrom
openspiel-catalog-alt
Jun 5, 2026
Merged

Load OpenSpiel games via Gambit Catalog#917
tturocy merged 13 commits into
masterfrom
openspiel-catalog-alt

Conversation

@edwardchalstrey1
Copy link
Copy Markdown
Member

@edwardchalstrey1 edwardchalstrey1 commented Jun 3, 2026

Issues closed by this PR

Described in #760 but this only does OpenSpiel and only games that currently work

Description of the changes in this PR

  • This PR is an alternative to Add games from OpenSpiel to catalog #878 that allows direct loading of OpenSpiel games compatible with (can be exported to) Gambit
  • Allows the user to do gbt.catalog.load_openspiel("tiny_hanabi")
  • Updates the documentation including OpenSpiel tutorial to load games via the catalog
  • Uses mocking to test the OpenSpiel loading - users are not expected to have this installed
  • Crucially, this code shouldn't need to be changed when more OpenSpiel games become exportable to NFG or EFG

How to review this PR

  • Review `load_openspiel and testing strategy
  • Review explanations in catalog doc page and OpenSpiel tutorial

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edwardchalstrey1 edwardchalstrey1 changed the title Openspiel catalog alt Load OpenSpiel games via Gambit Catalog Jun 3, 2026
@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review June 3, 2026 14:54
Comment thread src/pygambit/catalog.py Outdated
Comment thread src/pygambit/catalog.py Outdated
Comment thread src/pygambit/catalog.py
@edwardchalstrey1 edwardchalstrey1 requested a review from tturocy June 4, 2026 10:06
@edwardchalstrey1
Copy link
Copy Markdown
Member Author

Thanks for your comments @tturocy was an easy refactor have a separate load_openspiel function to call - you can now pass the params in there

Comment thread src/pygambit/catalog.py Outdated
edwardchalstrey1 and others added 2 commits June 4, 2026 15:33
…ynamics-based selection and don't include OpenSpiel's own errors
@tturocy tturocy merged commit e8ea505 into master Jun 5, 2026
25 of 26 checks passed
@tturocy tturocy deleted the openspiel-catalog-alt branch June 5, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants