Skip to content

Feat (Video Popup): add video schema#3465

Merged
bfintal merged 5 commits into
developfrom
fix/3402-video-popup-schema
May 7, 2025
Merged

Feat (Video Popup): add video schema#3465
bfintal merged 5 commits into
developfrom
fix/3402-video-popup-schema

Conversation

@kaeizen
Copy link
Copy Markdown
Contributor

@kaeizen kaeizen commented Mar 25, 2025

fixes #3402

Also added description in the schema to prevent "non-critical issues" flag in the validation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

🤖 Pull request artifacts

file commit
pr3465-stackable-3465-merge.zip 61fd584

github-actions Bot added a commit that referenced this pull request Mar 25, 2025
github-actions Bot added a commit that referenced this pull request Mar 25, 2025
github-actions Bot added a commit that referenced this pull request Mar 25, 2025
Comment thread src/block/video-popup/index.php Outdated
Comment thread src/block/video-popup/index.php Outdated
Comment thread src/block/video-popup/index.php Outdated
Comment thread src/block/video-popup/index.php Outdated
Comment thread src/block/video-popup/index.php Outdated
github-actions Bot added a commit that referenced this pull request Apr 11, 2025
Comment thread src/block/countdown/editor.scss Outdated
@@ -1,4 +1,4 @@
.ugb-panel--countdown .components-datetime__time-wrapper {
:is(.ugb-panel--countdown, .ugb-panel--video-popup) .components-datetime__time-wrapper {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is adding extra styles tot he datetime picker. Instead of explicitly adding the class names for the countdown and video popup blocks, can we style the datetime component when it's used in the Stackable block inspector in general? Please move these styles for the datetime outside the countdown editor.scss into somewhere more proper.

github-actions Bot added a commit that referenced this pull request Apr 15, 2025
@bfintal bfintal merged commit 81f66f9 into develop May 7, 2025
6 of 8 checks passed
@bfintal bfintal deleted the fix/3402-video-popup-schema branch May 7, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video Popup Block: Add Video Schema output

2 participants