Feat (Video Popup): add video schema#3465
Merged
Merged
Conversation
🤖 Pull request artifacts
|
bfintal
requested changes
Apr 10, 2025
bfintal
requested changes
Apr 15, 2025
| @@ -1,4 +1,4 @@ | |||
| .ugb-panel--countdown .components-datetime__time-wrapper { | |||
| :is(.ugb-panel--countdown, .ugb-panel--video-popup) .components-datetime__time-wrapper { | |||
Contributor
There was a problem hiding this comment.
Looks like this is adding extra styles tot he datetime picker. Instead of explicitly adding the class names for the countdown and video popup blocks, can we style the datetime component when it's used in the Stackable block inspector in general? Please move these styles for the datetime outside the countdown editor.scss into somewhere more proper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3402
Also added
descriptionin the schema to prevent "non-critical issues" flag in the validation.