Fix deprecated fct_explicit_na() in ch13 used-cars script#146
Open
gbekes wants to merge 1 commit into
Open
Conversation
forcats removed fct_explicit_na() (defunct as of forcats 1.0.0, deprecated earlier). The sample-design block in ch13-used-cars.R now errors on current forcats. Replace with fct_na_value_to_level(), the documented replacement, mapping na_level= to level=. Behaviour is unchanged: NA factor levels are still relabelled "Missing". Verified the downstream regressions (Table 13.2, models 1-4) reproduce the expected R-squared ladder (0.847 -> 0.919, N=281). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sample-design block in
ch13-used-cars-reg/ch13-used-cars.Rcallsfct_explicit_na(), whichforcatsdeprecated and then made defunct in 1.0.0. On currentforcatsthe script errors out before any regressions run.This swaps the six calls to the documented replacement,
fct_na_value_to_level()(note the argument renamena_level=→level=):Why it's safe
Behaviour is identical — NA factor levels are still relabelled
"Missing". I ran the downstream linear regressions (Table 13.2, models 1–4) after the change and they reproduce the expected fit: R² climbing 0.847 → 0.898 → 0.913 → 0.919 on N = 281 (Chicago sample).Scope is intentionally minimal: only the deprecated calls are touched, no change to model specs, table code, or house style.
🤖 Generated with Claude Code