Fixed clang compile and bad_alloc error; works on MacOSX#1
Open
jeffreybarrick wants to merge 1 commit into
Open
Fixed clang compile and bad_alloc error; works on MacOSX#1jeffreybarrick wants to merge 1 commit into
jeffreybarrick wants to merge 1 commit into
Conversation
Author
|
Oops. Apologies. I see the official version of this is on SourceForge. I'll contact the maintainers there... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've been working to get the conda package for isescan to work on MacOSX and found that there was a known incompatibility due to a bad_alloc error when it called FragGeneScan.
I figured out that this was due to a different default (smaller and insufficient) heap size for threads on MacOSX. This pull request should fix that.
I've tested that it runs and compiles on MacOSX and Linux.
It would be awesome if you could check that and roll a new official version of FragGeneScan with the update so that will propagate to BioConda.