Skip to content

fix: add clin sig prop as valid statement proposition#57

Merged
jsstevenson merged 3 commits into
1.1.0-snapshot.2026-02from
trying-stuff
Jun 11, 2026
Merged

fix: add clin sig prop as valid statement proposition#57
jsstevenson merged 3 commits into
1.1.0-snapshot.2026-02from
trying-stuff

Conversation

@jsstevenson

@jsstevenson jsstevenson commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
  • Add ClinicalSignificance proposition to Statement proposition property annotation
  • Refactor out to shared type alias

@jsstevenson jsstevenson requested a review from korikuzma June 11, 2026 01:15

@korikuzma korikuzma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a comment saying that if SubjectVariantProposition.root gets updated to update Statement.proposition? So that in the future, will remember to update in both places?

@jsstevenson

Copy link
Copy Markdown
Contributor Author

Could we add a comment saying that if SubjectVariantProposition.root gets updated to update Statement.proposition? So that in the future, will remember to update in both places?

I refactored out to a separate type alias so that it only gets changed in one place -- tests pass locally, I think this should work?

@jsstevenson jsstevenson requested a review from korikuzma June 11, 2026 14:22

@korikuzma korikuzma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@jsstevenson jsstevenson merged commit ab53535 into 1.1.0-snapshot.2026-02 Jun 11, 2026
8 checks passed
@jsstevenson jsstevenson deleted the trying-stuff branch June 11, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants