feat!: add predefined relations constants (#43)#46
Merged
Conversation
close #42 * Move enums `Relation` and `SystemUri` to `relations` module * Add `required_relations` method to `ProteinSequenceConsequence` and `CanonicalAllele` * Clean up validator code
|
This looks really nice! To potentially avoid an additional PR, do you think that it makes sense to wait until Cat-VRS #207: Implementation Guidance is done and discussed? In particular, this is going to bring up "spicy" (@DanielPuthawala 's words) conversations about required relations terms. |
Collaborator
Author
|
@brendanreardon TBH would love to get this in now and use it in some CIViCpy work, but I can wait. Just lmk |
brendanreardon
approved these changes
Jun 4, 2026
brendanreardon
left a comment
brendanreardon
left a comment
There was a problem hiding this comment.
Thank you, Kori! This looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git cherry-pick 87b7695b88dd8dc1e8f071910873deeb632e162bWould like to make a
0.8.0-a2release once this is merged.RelationandSystemUritorelationsmodulerequired_relationsmethod toProteinSequenceConsequenceandCanonicalAllele