Create WPEFramework_boot.service - #11
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new systemd oneshot unit intended to run a WPEFramework “boot” plugin activation step as part of the WPEFramework startup flow.
Changes:
- Introduces
WPEFramework_boot.serviceas a oneshot unit that runsPluginActivator org.rdk.boot. - Adds dependency declarations and a
ConditionPathExists=/tmp/wpeframeworkstartedgate.
| [Service] | ||
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=/usr/bin/PluginActivator org.rdk.boot |
There was a problem hiding this comment.
This unit currently has no [Install] section and there are no references to WPEFramework_boot.service elsewhere in the repo, so it won’t be started unless something external enables it or adds it as a dependency. Please either add proper boot integration ([Install] / WantedBy=) or ensure it’s pulled in by an existing target/path unit used to start WPEFramework plugin initializer services.
| ExecStart=/usr/bin/PluginActivator org.rdk.boot | |
| ExecStart=/usr/bin/PluginActivator org.rdk.boot | |
| [Install] | |
| WantedBy=multi-user.target |
| [Unit] | ||
| Description=WPEFramework boot Initialiser |
There was a problem hiding this comment.
The unit filename and implied unit name use mixed/upper casing (WPEFramework_boot.service) while the other WPEFramework-related unit files in systemd/system/ are consistently lowercase (wpeframework-*.service). Consider renaming this unit to match the established naming pattern to avoid confusion and reduce the chance of missing it in scripts/tooling that assume lowercase names.
| @@ -0,0 +1,8 @@ | |||
| [Unit] | |||
| Description=WPEFramework boot Initialiser | |||
| Requires=wpeframework.service wpeframework-persistentstore.service wpeframework-system.service wpeframework-deviceinfo.service | |||
There was a problem hiding this comment.
Requires= does not enforce startup ordering; without a matching After= this unit may start before its prerequisites and then get skipped by ConditionPathExists (or fail if dependencies aren’t ready). This repo’s WPEFramework plugin initializer units consistently pair Requires= with After= for the same services (e.g., systemd/system/wpeframework-deviceinfo.service:3-4). Please add an After= line mirroring the required units.
| Requires=wpeframework.service wpeframework-persistentstore.service wpeframework-system.service wpeframework-deviceinfo.service | |
| Requires=wpeframework.service wpeframework-persistentstore.service wpeframework-system.service wpeframework-deviceinfo.service | |
| After=wpeframework.service wpeframework-persistentstore.service wpeframework-system.service wpeframework-deviceinfo.service |
No description provided.