ci: separate rustdesk-unattended-wayland deb for the drm feature#6
Closed
fxd0h wants to merge 2 commits into
Closed
ci: separate rustdesk-unattended-wayland deb for the drm feature#6fxd0h wants to merge 2 commits into
fxd0h wants to merge 2 commits into
Conversation
hzhou asked for the drm/kms capture to ship as its own deb instead of baked into the stock package, so installing it is an explicit choice. build.py now names the --drm build rustdesk-unattended-wayland (Conflicts/Replaces/Provides rustdesk — install one or the other, they share files), and the linux CI job builds it as a separate x86_64 artifact after the stock deb/rpm so the drm relink cant leak into them.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
0.4.5 guards the HDR metadata readout behind a build-time feature probe so the drm C sources compile against an older libdrm (the CI deb-build container), not only modern desktops. Fixes the unattended-wayland deb build in CI.
Owner
Author
|
squashed into feature/drm-capture-clean and pushed to rustdesk#15420; CI green (the unattended-wayland deb builds with libdrmtap-sys 0.4.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal test pass. Adds a separately-named opt-in deb for the DRM/KMS unattended-wayland capture (hzhou's request). build.py names the --drm build
rustdesk-unattended-wayland(Conflicts/Replaces/Provides rustdesk), and the linux CI job builds it as a separate x86_64 artifact after the stock deb/rpm. Validated locally: control (Conflicts/Replaces + libcap2-bin), helper at /usr/lib/rustdesk/drmtap-helper, postinst setcap. This run is to confirm the CI wiring.