Skip to content

Regionprops node features#29

Draft
cmalinmayor wants to merge 8 commits into
mainfrom
regionprops_node_features
Draft

Regionprops node features#29
cmalinmayor wants to merge 8 commits into
mainfrom
regionprops_node_features

Conversation

@cmalinmayor

Copy link
Copy Markdown
Collaborator

Proposed Change

Add additional node features from regionprops and optionally pass in intensity image to compute said features.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@cmalinmayor cmalinmayor force-pushed the regionprops_node_features branch from b01a212 to 00473f4 Compare February 25, 2025 19:46
@codecov-commenter

codecov-commenter commented Feb 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 62.69841% with 47 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (6c337e4) to head (b618716).

Files with missing lines Patch % Lines
...le_toolbox/candidate_graph/regionprops_extended.py 43.83% 41 Missing ⚠️
src/motile_toolbox/candidate_graph/utils.py 80.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   87.75%   81.94%   -5.81%     
==========================================
  Files          14       15       +1     
  Lines         449      565     +116     
==========================================
+ Hits          394      463      +69     
- Misses         55      102      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I am not entirely sure this is the best way to do this. However,
it is better than lumping them all together and passing in lists
of strings to the function.
@cmalinmayor

Copy link
Copy Markdown
Collaborator Author

Discussed with Anniek - this PR is not a priority right now for motile_tracker work. However, it still can be useful in the toolbox. Needed work includes:

  • docstrings for the new features including description of what it means and where formula came from
  • tests for new features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants